Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename project to "terminus" #877

Closed
ari-gold opened this issue Feb 4, 2016 · 11 comments
Closed

Rename project to "terminus" #877

ari-gold opened this issue Feb 4, 2016 · 11 comments

Comments

@ari-gold
Copy link
Contributor

ari-gold commented Feb 4, 2016

Problem:

Google for "pantheon terminus" and top result is the deprecated project. Reported by Marketing

Proposed solution:

According to https://github.com/blog/1508-repository-redirects-are-here renaming a repo adds a redirect so:

  1. Renaming https://github.com/pantheon-systems/terminus/ to https://github.com/pantheon-systems/terminus-deprecated
    and
  2. Renaming https://github.com/pantheon-systems/cli to https://github.com/pantheon-systems/terminus

will have the desired effect that:

  • Someone visits cli or terminus they'll end up on terminus project page
  • People will need to go directly to terminus-deprecated to reach that deprecated project

I tested this with my forks and it seemed to work fine. Does this sound like a reasonable solution?

@bmackinney
Copy link
Contributor

+1. Does composer respect the redirects? I imagine it would.

@bmackinney
Copy link
Contributor

It seems not: composer/packagist#496

@ari-gold
Copy link
Contributor Author

ari-gold commented Feb 8, 2016

@bensheldon @TeslaDethray Can we do this today or tomorrow?

@bensheldon
Copy link
Contributor

@ari-gold can you put together a rollout plan that includes a customer notification and any updates to docs or links? That composer link above seems to imply composer won't automatically redirect and folks will probably need to update their scripts if they're manually fetching packages from github.

ari-gold added a commit to ari-gold/terminus that referenced this issue Feb 8, 2016
ari-gold added a commit to pantheon-systems/documentation that referenced this issue Feb 8, 2016
ari-gold added a commit to ari-gold/terminus that referenced this issue Feb 8, 2016
@ari-gold
Copy link
Contributor Author

ari-gold commented Feb 8, 2016

@bensheldon I've referenced PRs to update relevant docs on pantheon.io/docs as well as this README and CHANGELOG. Do you think that covers everything? /cc @bmackinney @TeslaDethray

@bmackinney
Copy link
Contributor

https://packagist.org/packages/pantheon-systems/terminus is marked abandoned already. We should investigate whether that can be reversed. @greg-1-anderson owns that project on packagist.

@bensheldon I think if scripts download /cli directly from github, it should respect the redirect to the new/old url, but yes they'll generally want to update scripts. We should also email the power-users list.

On Packagist:

  • Add a new package
  • Abandon pantheon-systems/cli ad point to pantheon-systems/terminus
  • un-abandon pantheon-systems/terminus? @greg-1-anderson

@bensheldon
Copy link
Contributor

@bmackinney I can un-abandon the project... oops, I guess I just did.

@bensheldon
Copy link
Contributor

I've renamed the repos:

  • pantheon-systems/terminus -> pantheon-systems/terminus-deprecated
  • pantheon-systems/cli -> pantheon-systems/terminus

And I've updated the Packagist projects to be either abandoned/redirected, with the proper source being pantheon-systems/terminus

screen shot 2016-02-08 at 1 17 37 pm

@greg-1-anderson
Copy link
Member

+1 looks like that will work. Screen shot is out-of-date, though; are the projects set to auto-update in Packagist? Can github auto-update more than one Packagist package per repository?

@bensheldon
Copy link
Contributor

@greg-1-anderson it seems like the auto-update logic lives in Github, rather than Packagist. We're firing off the github webhook at Packagist, and Packagist must auto-update (one/any?) project that matches the git repo for the webhook. So it's wired up right, we'll just have to see if Packagist will update them appropriately.

@greg-1-anderson
Copy link
Member

Yep, both pantheon-systems/terminus and pantheon-systems/cli are showing the right info, and the "(Not Auto-Updated)" tag shown in the screenshot above has been removed on Packagist, so it seems that all should be fine now. Folks will get the right thing from Composer if they require pantheon-systems/terminus or pantheon-systems/cli.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants