Update PccSiteViewQuery.php #32
Open
+6
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I didn't want to file a PR for every tiny edit. There's no reason to take an object by reference unless you want to replace the object itself. `getPublishingLevel` already uses `match` so why not. However, `toRow` collecting into a row key called `index` makes me wonder a little: is there a possible problem with a collision with a future field called `index` ? If yes what could be done to mitigate this? Is it possible to separate into $row['index'] and $row['data'] where the latter would be the field indexed data structure currently in `$row`? If not because this structure goes into core Views then at least name thing much less likely to collide like `__index` maybe?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I didn't want to file a PR for every tiny edit.
There's no reason to take an object by reference unless you want to replace the object itself.
getPublishingLevelalready usesmatchso why not.However,
toRowcollecting into a row key calledindexmakes me wonder a little: is there a possible problem with a collision with a future field calledindex? If yes what could be done to mitigate this? Is it possible to separate into $row['index'] and $row['data'] where the latter would be the field indexed data structure currently in$row? If not because this structure goes into core Views -- haven't stepped through the whole thing yes, just reading it -- then at least name thing much less likely to collide like__indexmaybe?