Fixes PHPCS Errors based on WPCS #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Please note that there is currently one error remaining and is blocked by #48.
|
Please do note that, at the creation of this PR, I have not tested these changes functionally. That is the next step. |
# Conflicts: # pantheon-hud.php
|
@danielbachhuber I updated the PHPCS config with the config file you reference and removed the unnecessary configuration. I did not change the PHP or WP version compatibility requirement configuration, as I am not of those without further digging. Hoping @ataylorme or yourself will know those minimum requirements. Either way, these need to be updated. Let me know if there is something else missing. |
| @@ -1,42 +1,45 @@ | |||
| <?php | |||
| /** | |||
| * Plugin Name: Pantheon HUD | |||
| * Version: 0.2.2 | |||
| * Version: 0.2.1 | |||
There was a problem hiding this comment.
Suggested change
| * Version: 0.2.1 | |
| * Version: 0.2.2 |
danielbachhuber
changed the title
|
Looks great, thanks for your work on this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This covers a first stab at fixing some of the PHPCS errors, which will enable us to test next iterations of this plugin more easily.
Currently there is one final error to fix and it is blocked by #48.
Fixes #33