Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CMS-1117] Test PHP 8.2 #110

Merged
merged 25 commits into from
Jan 23, 2023
Merged

[CMS-1117] Test PHP 8.2 #110

merged 25 commits into from
Jan 23, 2023

Conversation

jspellman814
Copy link

No description provided.

@jspellman814 jspellman814 force-pushed the cms-1117 branch 3 times, most recently from ac5b95a to 50cf9e7 Compare December 19, 2022 18:02
@jspellman814 jspellman814 changed the title [CMS-1117] Test more versions of PHP [CMS-1117] Test PHP 8.2 Dec 19, 2022
@jspellman814 jspellman814 marked this pull request as ready for review January 19, 2023 23:22
@jspellman814 jspellman814 requested a review from a team as a code owner January 19, 2023 23:22
jazzsequence
jazzsequence previously approved these changes Jan 23, 2023
Copy link
Contributor

@jazzsequence jazzsequence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, should those two Quay images be PHP 8.2 rather than PHP 8.1?

@jspellman814
Copy link
Author

Yeah should have been. Updated!

@jspellman814 jspellman814 requested review from jazzsequence and a team January 23, 2023 17:00
Copy link
Contributor

@jazzsequence jazzsequence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@jspellman814 jspellman814 merged commit ed83ab8 into develop Jan 23, 2023
@jspellman814 jspellman814 deleted the cms-1117 branch January 23, 2023 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants