Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PCC 792] Add file smart component field type #134

Merged
merged 3 commits into from
Dec 5, 2023
Merged

[PCC 792] Add file smart component field type #134

merged 3 commits into from
Dec 5, 2023

Conversation

a11rew
Copy link
Collaborator

@a11rew a11rew commented Dec 5, 2023

Changes

  • Adds new file smart component field type
  • Makes required and displayName fields required, bringing the smart component type in the SDK to parity with the type expected serverside.
  • Adds some type assertions in Typescript starters, fixing type errors.

@a11rew a11rew requested review from kevinstubbs and aumkar December 5, 2023 11:12
@a11rew a11rew merged commit 4bf2d06 into main Dec 5, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinstubbs kevinstubbs kevinstubbs approved these changes

@aumkar aumkar Awaiting requested review from aumkar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@a11rew @kevinstubbs