Merge pull request #145 from pantheon-systems/PCC-858-update-to-lates…

…t-octokit-version Pcc 858 update to latest octokit version. Use node 18 instead of 16.
pantheon-systems · Dec 26, 2023 · 843ac36 · 843ac36
2 parents 37205e0 + 85fb982
commit 843ac36
Show file tree

Hide file tree

Showing 7 changed files with 6,431 additions and 4,227 deletions.
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -34,7 +34,7 @@ jobs:
       - name: Setup nodejs
         uses: actions/setup-node@v3
         with:
-          node-version: 16
+          node-version: 18
           cache: "pnpm"
 
       - name: Install dependencies

diff --git a/packages/cli/package.json b/packages/cli/package.json
@@ -34,7 +34,7 @@
     "preinstall": "node scripts/checkNodeVersion.js"
   },
   "engines": {
-    "node": ">=16.0.0"
+    "node": ">=18.0.0"
   },
   "dependencies": {
     "@pantheon-systems/pcc-sdk-core": "latest",
@@ -47,7 +47,7 @@
     "google-auth-library": "^8.9.0",
     "inquirer": "^8.2.6",
     "nunjucks": "^3.2.4",
-    "octokit": "^2.1.0",
+    "octokit": "^3.1.2",
     "open": "^9.1.0",
     "ora": "^6.3.1",
     "package-json": "^8.1.1",

diff --git a/packages/cli/src/cli/commands/init.test.ts b/packages/cli/src/cli/commands/init.test.ts
@@ -10,7 +10,17 @@ const PCC = "./dist/index.js";
 const defaultArgs = ["--non-interactive", "--noInstall", "--verbose"];
 
 const executePCC = async (command: string, args: string[]) => {
-  return await sh("node", [PCC, command, ...args, ...defaultArgs], true);
+  try {
+    return await sh("node", [PCC, command, ...args, ...defaultArgs], true);
+  } catch (e) {
+    console.error("executePCC encountered an issue", e, "args used:", [
+      PCC,
+      command,
+      ...args,
+      ...defaultArgs,
+    ]);
+    throw e;
+  }
 };
 
 test("should be able to init starter kit for nextjs template", async () => {

diff --git a/packages/react-sample-library/package.json b/packages/react-sample-library/package.json
@@ -33,7 +33,7 @@
     }
   },
   "engines": {
-    "node": ">=16.0.0"
+    "node": ">=18.0.0"
   },
   "devDependencies": {
     "@storybook/addon-essentials": "^7.6.6",

diff --git a/packages/react-sdk/package.json b/packages/react-sdk/package.json
@@ -71,7 +71,7 @@
     "eslint": "8.46.0",
     "eslint-config-pcc-custom": "workspace:*",
     "jest": "29.5.0",
-    "octokit": "^2.1.0",
+    "octokit": "^3.1.2",
     "ora": "^6.3.1",
     "react": "18.2.0",
     "react-dom": "18.2.0",

diff --git a/packages/vue-sdk/package.json b/packages/vue-sdk/package.json
@@ -48,7 +48,7 @@
     "lint:fix": "eslint . --fix && prettier --write . && tsc --noEmit"
   },
   "engines": {
-    "node": ">=16.0.0"
+    "node": ">=18.0.0"
   },
   "devDependencies": {
     "@types/markdown-it": "^13.0.2",