[BUGS-8452] remove nonce_life filter
#293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this way it's easier to debug because we can show people where they've added the filter
if it's in an anonymous function, we note that.
so we don't need to reset it to the string we want to output later
not used
these aren't valid versions, so version_compare freaks out and (incorrectly) flags 6.7-alpha-whatever as less than 6.7 🤦♂️
instead define an action that can be called by users
reframe this to be used in a `do_action` by customers who are need to make this change to alter the cache lifetime for nonces
remove duplicated section about the cache max age filter
pwtyler
approved these changes
Aug 6, 2024
Base automatically changed from
bugs-8452-add-callback-info-to-filtered-message
to
develop
August 6, 2024 16:58
so it's set when we start the tests
we can assume the setting doesn't exist
we're testing this with unit tests and this is being annoying in behat
|
Composer Changes
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the
add_filterto hookpantheon_cache_default_max_agetononce_lifeminus 1 hour. This was overriding the cache age and hard-coding cache lifetimes to 23 hours.Instead, this is replaced by a new action,
pantheon_cache_nonce_lifetimewhich can be called in ado_actionwhen needed.Behat tests Blocked by pantheon-systems/pantheon-wordpress-upstream-tests#67