Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGS-7429] Add filter to exclude select post types from purge #258

Merged
merged 46 commits into from
Mar 11, 2024

Conversation

jazzsequence
Copy link
Contributor

@jazzsequence jazzsequence commented Feb 26, 2024

Update the Purger class to add a filter that allows users skip purges if a given post type is being updated.

This PR has been updated to include various CI tweaks.

  • we're using wpunit-helpers
  • I've broken validate-fixture-version.sh into a separate gist with the goal of standardizing that script and making it more robust
  • since the filter is a feature add, I've bumped the versions everywhere to 1.5.0-dev

Copy link
Contributor

github-actions bot commented Feb 26, 2024

Composer Changes

Dev Packages Operation Base Target
nikic/php-parser Upgraded v5.0.0 v5.0.1
pantheon-systems/wpunit-helpers New - v2.0.0
phpstan/phpdoc-parser Upgraded 1.25.0 1.26.0
phpunit/phpunit Upgraded 9.6.16 9.6.17
squizlabs/php_codesniffer Upgraded 3.8.1 3.9.0

@jazzsequence jazzsequence changed the base branch from master to develop February 26, 2024 22:33
@jazzsequence jazzsequence changed the title Bugs-7429-exclude-from-purge-filter [BUGS-7429] Add filter to exclude select post types from purge Mar 5, 2024
@jazzsequence jazzsequence marked this pull request as ready for review March 5, 2024 21:33
@jazzsequence jazzsequence requested a review from a team as a code owner March 5, 2024 21:33
Copy link
Member

@pwtyler pwtyler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is superfluous if we're going to ship a release immediately, but in general, prefer to use the x.y.z-dev version in documentation and docblocks, then search-replace as part of release prep. It could sit on develop and then subsequent feature bump to a minor/major vn, "@SInCE" will then point to a non-existent version.

if we ever get to implementing, plugin release actions should handle inside php files already.

.github/workflows/lint-test.yml Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@jazzsequence jazzsequence self-assigned this Mar 6, 2024
@jazzsequence jazzsequence merged commit d147b27 into develop Mar 11, 2024
10 checks passed
@jazzsequence jazzsequence deleted the bugs-7429-exclude-from-purge-filter branch March 11, 2024 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants