Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CMSP-71] PHP 8.2 compatibility #218

Merged
merged 1 commit into from
Mar 13, 2023
Merged

[CMSP-71] PHP 8.2 compatibility #218

merged 1 commit into from
Mar 13, 2023

Conversation

jspellman814
Copy link

No description provided.

@jspellman814 jspellman814 requested a review from a team as a code owner March 10, 2023 19:27
"dealerdirect/phpcodesniffer-composer-installer": "^1.0.0",
"phpunit/phpunit": "^7",
"phpunit/phpunit": "^9",
"phpcompatibility/php-compatibility": "^9.3",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note php-compatibility ^9.3 does not have any PHP 8 testing (although default branch does)

@jspellman814 jspellman814 merged commit 05b7e24 into develop Mar 13, 2023
@jspellman814 jspellman814 deleted the cmsp-131 branch March 13, 2023 18:44
jspellman814 pushed a commit that referenced this pull request Mar 14, 2023
jspellman814 pushed a commit that referenced this pull request Mar 14, 2023
jspellman814 pushed a commit that referenced this pull request Mar 15, 2023
* Bump yoast/phpunit-polyfills from 1.0.3 to 1.0.4

Bumps [yoast/phpunit-polyfills](https://github.com/Yoast/PHPUnit-Polyfills) from 1.0.3 to 1.0.4.
- [Release notes](https://github.com/Yoast/PHPUnit-Polyfills/releases)
- [Changelog](https://github.com/Yoast/PHPUnit-Polyfills/blob/develop/CHANGELOG.md)
- [Commits](Yoast/PHPUnit-Polyfills@1.0.3...1.0.4)

---
updated-dependencies:
- dependency-name: yoast/phpunit-polyfills
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

* Test more versions of PHP (#218)

* Release 1.2.2

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
jazzsequence added a commit that referenced this pull request Mar 21, 2023
* Bump yoast/phpunit-polyfills from 1.0.3 to 1.0.4

Bumps [yoast/phpunit-polyfills](https://github.com/Yoast/PHPUnit-Polyfills) from 1.0.3 to 1.0.4.
- [Release notes](https://github.com/Yoast/PHPUnit-Polyfills/releases)
- [Changelog](https://github.com/Yoast/PHPUnit-Polyfills/blob/develop/CHANGELOG.md)
- [Commits](Yoast/PHPUnit-Polyfills@1.0.3...1.0.4)

---
updated-dependencies:
- dependency-name: yoast/phpunit-polyfills
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

* Test more versions of PHP (#218)

* Release 1.2.2

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
jazzsequence added a commit that referenced this pull request Apr 6, 2023
* [CMS-1033] Add GH action for deployments to wp.org (#203)

* Cleanup distignore

* Link readme files to new contrib doc

* Add CONTRIBUTING.md, add automation for wp.org

* distignore behat.yml

* add CODEOWNERS and distignore

* Add assets

* Fix GH action (#205)

* Make dependabot target develop branch (#209)

* Bump dealerdirect/phpcodesniffer-composer-installer from 0.7.2 to 1.0.0

Bumps [dealerdirect/phpcodesniffer-composer-installer](https://github.com/Dealerdirect/phpcodesniffer-composer-installer) from 0.7.2 to 1.0.0.
- [Release notes](https://github.com/Dealerdirect/phpcodesniffer-composer-installer/releases)
- [Changelog](https://github.com/PHPCSStandards/composer-installer/blob/main/.github_changelog_generator)
- [Commits](PHPCSStandards/composer-installer@v0.7.2...v1.0.0)

---
updated-dependencies:
- dependency-name: dealerdirect/phpcodesniffer-composer-installer
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>

* Bump dealerdirect/phpcodesniffer-composer-installer from 0.7.2 to 1.0.0

Bumps [dealerdirect/phpcodesniffer-composer-installer](https://github.com/Dealerdirect/phpcodesniffer-composer-installer) from 0.7.2 to 1.0.0.
- [Release notes](https://github.com/Dealerdirect/phpcodesniffer-composer-installer/releases)
- [Changelog](https://github.com/PHPCSStandards/composer-installer/blob/main/.github_changelog_generator)
- [Commits](PHPCSStandards/composer-installer@v0.7.2...v1.0.0)

---
updated-dependencies:
- dependency-name: dealerdirect/phpcodesniffer-composer-installer
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>

* handle models that are not instances of the Model class

* Bump grunt from 1.5.3 to 1.6.1

Bumps [grunt](https://github.com/gruntjs/grunt) from 1.5.3 to 1.6.1.
- [Release notes](https://github.com/gruntjs/grunt/releases)
- [Changelog](https://github.com/gruntjs/grunt/blob/main/CHANGELOG)
- [Commits](gruntjs/grunt@v1.5.3...v1.6.1)

---
updated-dependencies:
- dependency-name: grunt
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

* Bump yoast/phpunit-polyfills from 1.0.3 to 1.0.4

Bumps [yoast/phpunit-polyfills](https://github.com/Yoast/PHPUnit-Polyfills) from 1.0.3 to 1.0.4.
- [Release notes](https://github.com/Yoast/PHPUnit-Polyfills/releases)
- [Changelog](https://github.com/Yoast/PHPUnit-Polyfills/blob/develop/CHANGELOG.md)
- [Commits](Yoast/PHPUnit-Polyfills@1.0.3...1.0.4)

---
updated-dependencies:
- dependency-name: yoast/phpunit-polyfills
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

* Test more versions of PHP (#218)

* add our coding standards

* ignore tests/

* phpcbf changes

* ignore the rule that doesn't matter

* ignore nonce check

* sanitization fixes

* ignore missing param tags in docblocks for cli commands

* ignore sniffs for unused variables
while the variables aren't used, the functions that are extended might still expect the param to exist, so we're just going to ignore the sniff

* spacing

* ignore some annoying sniffs

* explain why we are ignoring sniffs at the file level

* use php 8.1 image for linting

* use php8.0 image for linting

* return type must be void

* ignore platform requirements for composer install
don't error for < php8.0 when running 7.4 tests

* Release 1.2.2 (#219)

* Bump yoast/phpunit-polyfills from 1.0.3 to 1.0.4

Bumps [yoast/phpunit-polyfills](https://github.com/Yoast/PHPUnit-Polyfills) from 1.0.3 to 1.0.4.
- [Release notes](https://github.com/Yoast/PHPUnit-Polyfills/releases)
- [Changelog](https://github.com/Yoast/PHPUnit-Polyfills/blob/develop/CHANGELOG.md)
- [Commits](Yoast/PHPUnit-Polyfills@1.0.3...1.0.4)

---
updated-dependencies:
- dependency-name: yoast/phpunit-polyfills
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

* Test more versions of PHP (#218)

* Release 1.2.2

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* bump version

* add chris and john to contributors

* add cms-platform to codeowners

* update changelog

* update the lockfile

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: John Spellman <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants