Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUGS-5812] handle models that are not instances of the Model class #212

Merged
merged 1 commit into from
Feb 22, 2023
Merged

[BUGS-5812] handle models that are not instances of the Model class #212

merged 1 commit into from
Feb 22, 2023

Conversation

jspellman814
Copy link

Props to @macbookandrew 🎉

This is a copy of #208 that will run against our test suite. Addresses #202.

@jspellman814 jspellman814 requested a review from a team as a code owner January 27, 2023 16:34
@jspellman814 jspellman814 mentioned this pull request Jan 27, 2023
Closed
pwtyler
pwtyler approved these changes Jan 27, 2023
View reviewed changes
Copy link
Member

@pwtyler pwtyler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only question is if there is anything about mixed types + PHP8 we might consider informing this, but I expect PHP8 is somewhat irrelevant due to backwards compat requirements.

jazzsequence
jazzsequence approved these changes Feb 1, 2023
View reviewed changes
Copy link
Contributor

@jazzsequence jazzsequence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:rubberstamp:

@jspellman814 jspellman814 merged commit 044690b into develop Feb 22, 2023
@jspellman814 jspellman814 deleted the bugs-5812 branch February 22, 2023 19:04
@jspellman814 jspellman814 mentioned this pull request Feb 23, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pwtyler pwtyler pwtyler approved these changes

@jazzsequence jazzsequence jazzsequence approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jspellman814 @jazzsequence @pwtyler