Server tests #337
Merged
Server tests #337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dev to yolo: time tests
Yolo to stage: time tests
Stage to master: time tests
jerryblakley
added
workflow/in-progress
in progress
and removed
workflow/in-progress
labels
jerryblakley
commented
Feb 28, 2017
tests/server-tests/api_test.go
Outdated
| @@ -15,7 +15,7 @@ func newrequest(file string, method string, body io.Reader) (*http.Request, erro | |||
| req, err := http.NewRequest(method, file, body) | |||
| if err != nil { | |||
| // handle err | |||
| fmt.Errorf("Error on NewRequest; exiting...") | |||
| err = fmt.Errorf("Error on NewRequest; exiting...") | |||
There was a problem hiding this comment.
Not sure I understand. Aren't we wiping out the err we want to pass back?
jerryblakley
commented
Feb 28, 2017
tests/server-tests/api_test.go
Outdated
| @@ -47,17 +48,17 @@ func testMKCOL(t *testing.T, client *http.Client, dirname string) (string, error | |||
| req, err := newrequest(dirname, "MKCOL", nil) | |||
| if err != nil { | |||
| // handle error | |||
| t.Errorf("testMKCOL: Error: %v", t) | |||
| t.Errorf("testMKCOL: Error: %v", err) | |||
There was a problem hiding this comment.
't' instead of 'err' was probably just a brain fart on my part, but what would 't' print here? Anything extra of value?
jerryblakley
commented
Feb 28, 2017
tests/server-tests/api_test.go
Outdated
| if err != nil { | ||
| // handle err | ||
| fmt.Printf("Error on client.Do; err: %v, exiting ...\n", err) | ||
| t.Errorf("Error on client.Do; exiting...\n") | ||
| return "", err | ||
| } | ||
| defer resp.Body.Close() |
There was a problem hiding this comment.
Well done. I blindly followed a policy: put the defer next to the call.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still pretty much a WIP. Just basic API tests against a server.