forensic haven cleanup #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stage to master: change statsd defaults
jerryblakley
force-pushed
the
dev-forensic-haven
branch
from
20ac73e to
a29fd21
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there is an error writing a file, it gets added to the forensic haven. With this commit, whenever this happens, cleanup old files. Currently by default, no more than 8 files will be left in the forensic haven, and none older than 64 hours.
The function 'clear_files' is roughly the previous function 'cleanup_orphans' with some changes but moved to a different position in the file. 'cleanup_orphans' was called only in the context of the filecache_cleanup called whenever a binding restarts; now it is also called in the context of forensic haven.