Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forcing datetime to utc #84

Merged
merged 4 commits into from
Feb 17, 2020
Merged

Forcing datetime to utc #84

merged 4 commits into from
Feb 17, 2020

Conversation

wtgee
Copy link
Member

@wtgee wtgee commented Feb 14, 2020

Closes #83 and panoptes/POCS#949

@codecov-io
Copy link

codecov-io commented Feb 14, 2020 •
edited
Loading

Codecov Report

Merging #84 into develop will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #84      +/-   ##
===========================================
+ Coverage     62.3%   62.32%   +0.02%     
===========================================
  Files           49       49              
  Lines         3425     3427       +2     
  Branches       405      405              
===========================================
+ Hits          2134     2136       +2     
  Misses        1212     1212              
  Partials        79       79
Impacted Files Coverage Δ
panoptes/utils/tests/test_utils.py 98.96% <100%> (ø) ⬆️
panoptes/utils/time.py 94.23% <100%> (+0.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3263fcc...35dd8b1. Read the comment docs.

@wtgee wtgee requested a review from danjampro February 14, 2020 22:30
@wtgee wtgee added the Quick PR label Feb 16, 2020
@wtgee wtgee requested a review from AnthonyHorton February 17, 2020 02:34
AnthonyHorton
AnthonyHorton approved these changes Feb 17, 2020
View reviewed changes
Copy link
Collaborator

@AnthonyHorton AnthonyHorton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can avoid the pytz dependency.

panoptes/utils/tests/test_utils.py Outdated Show resolved Hide resolved
@wtgee wtgee merged commit cd8545c into panoptes:develop Feb 17, 2020
@wtgee wtgee deleted the current-time-utc-83 branch February 17, 2020 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AnthonyHorton AnthonyHorton AnthonyHorton approved these changes

@danjampro danjampro Awaiting requested review from danjampro

Assignees
No one assigned
Labels
Quick PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix current_time utc timezone
3 participants
@wtgee @codecov-io @AnthonyHorton