Weather sensor & plot updates #881
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Ability to specify `db_type` with a default of `file`. * Remove unused `get_reading`. * Messaging ports come from config instead of hard-coded. * Easier date parsing on plotting. * Plotting skips invalid entries. * Masked entries are filled with zeros (!)
Codecov Report
@@ Coverage Diff @@
## develop #881 +/- ##
========================================
Coverage 81.38% 81.38%
========================================
Files 69 69
Lines 5646 5646
Branches 781 781
========================================
Hits 4595 4595
Misses 850 850
Partials 201 201Continue to review full report at Codecov.
|
* Use only pandas tables, not astropy tables (makes working with dates easier). * Filter rows to only include relevant dates (speeds things up). * Use logger rather than print statements. * Update matplotlib date converters. * Create location for plotting using `create_location_from_config`. * Cleaned up date formatting for log output.
|
Closing this PR in favor of the separate repo at: https://github.com/panoptes/aag-weather Future PR should remove all weather info from POCS repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sensor:
db_typewith a default offile.get_reading.Plot script:
create_location_from_config.Pulled from #859