issue and pull request templates added #801
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #801 +/- ##
========================================
Coverage 81.21% 81.21%
========================================
Files 66 66
Lines 5515 5515
Branches 759 759
========================================
Hits 4479 4479
Misses 838 838
Partials 198 198Continue to review full report at Codecov.
|
|
Could you give feedback for my pull request @wtgee ? |
There was a problem hiding this comment.
Thanks @ImmortalRabbit. TBH, I'm not entirely sure what we want either which is why we've never taken action on it. However I think this is a good starting point. Can you change the one small sentence and then I'll go ahead and merge. Cheers!
ISSUE_TEMPLATE.md
Outdated
| ## Your Environment | ||
| <!--- Include as many relevant details about the environment you experienced the bug in --> | ||
| * Version used: python3.6+ | ||
| * Environment name and version (e.g. PHP 5.4 on nginx 1.9.1): |
There was a problem hiding this comment.
Let's take out the PHP example as that is potentially confusing. Ideally they are using anaconda so write something like "Python 3.7.1 on conda 4.6.3"
There was a problem hiding this comment.
Let's take out the PHP example as that is potentially confusing. Ideally they are using anaconda so write something like "Python 3.7.1 on conda 4.6.3"
Could you check my fix? I have just changed "PHP 5.4 on nginx 1.9.1" to "Python 3.7.1 on conda 4.6.3"
* Update issue templates The Community health check was showing missing Issue Templates even after #801, so I went through the github wizard and added these. The wording is largely the same as #801 but also adds two types. * Delete ISSUE_TEMPLATE.md The github wizards wants to name this something different and adds its own. Text copied from here to there.
Description
I did not decide to write templates by myself because I thought I am not that much experienced to write it. Therefore, I found understandable templates which have everything what issues and pull requests need to define.
Related Issue
#156
How Has This Been Tested?
I just look through pull requests that were made and decided to choose this template.
Types of changes
Checklist: