Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a DitheredObservation type - WIP #739

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Add a DitheredObservation type - WIP #739

wants to merge 2 commits into from

Conversation

wtgee
Copy link
Member

@wtgee wtgee commented Nov 25, 2018

Depends on #735

  • Rearrange to support mulitple types of Observations.
  • Add a DitheredObservation (coming from AstroHuntsman/huntsman-pocs).

@wtgee
DitheredObservation
e7b3c89 
Depends on panoptes#735

* Rearrange to support mulitple types of `Observation`s.
* Add a `DitheredObservation` (coming from AstroHuntsman/huntsman-pocs).
@wtgee wtgee added the One of Many PRs PR is part of a multi-part sequence of PRs label Nov 25, 2018
@wtgee wtgee mentioned this pull request Nov 25, 2018
Open
13 tasks
@codecov
Copy link

codecov bot commented Nov 25, 2018 •
edited
Loading

Codecov Report

Merging #739 into develop will decrease coverage by 0.62%.
The diff coverage is 2.77%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #739      +/-   ##
===========================================
- Coverage    80.58%   79.96%   -0.63%     
===========================================
  Files           61       62       +1     
  Lines         5188     5182       -6     
  Branches       715      709       -6     
===========================================
- Hits          4181     4144      -37     
- Misses         818      852      +34     
+ Partials       189      186       -3
Impacted Files Coverage Δ
pocs/scheduler/observation/base.py 94.73% <ø> (ø)
pocs/scheduler/observation/dithered.py 0% <0%> (ø)
pocs/scheduler/observation/__init__.py 100% <100%> (ø)
pocs/base.py

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0941fb...1f1eb62. Read the comment docs.

AnthonyHorton
AnthonyHorton approved these changes Nov 26, 2018
View reviewed changes
Copy link
Collaborator

@AnthonyHorton AnthonyHorton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, though I'm not very familiar with the Observation base class.

@wtgee wtgee changed the title Add a DitheredObservation type Add a DitheredObservation type - WIP Dec 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AnthonyHorton AnthonyHorton AnthonyHorton approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
One of Many PRs PR is part of a multi-part sequence of PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wtgee @AnthonyHorton