Remove support for the 'fileline' attribute in log formats #678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This non-standard attribute has been the cause of many problems, so reverting back to using only the default attributes.
wtgee
approved these changes
Oct 5, 2018
conf_files/log.yaml
Outdated
| @@ -7,8 +7,7 @@ logger: | |||
| datefmt: '%H:%M:%S' | |||
| detail: | |||
| style: '{' | |||
| # See FilenameLineFilter in logger.py for fileline description | |||
| format: '{levelname:.1s}{asctime}.{msecs:03.0f} {fileline:20s} {message}' | |||
| format: '{levelname:.1s}{asctime}.{msecs:03.0f} {filename} {lineno} {message}' | |||
There was a problem hiding this comment.
I'd prefer we still have a fixed length for filename and lineno so the the message always start with a left flush. I could live without but I think it makes reading easier.
Codecov Report
@@ Coverage Diff @@
## develop #678 +/- ##
==========================================
- Coverage 78.06% 77.9% -0.16%
==========================================
Files 61 61
Lines 5069 5064 -5
Branches 696 696
==========================================
- Hits 3957 3945 -12
- Misses 898 903 +5
- Partials 214 216 +2
Continue to review full report at Codecov.
|
|
Should fix #393. |
Right align the filename in a 25 char field space (if it fits), and pad the lineno to 3 chars with zero if lower than 100. For most of our files, this will result in a fixed length prefix before the message, thus making it somewhat easier to find the message.
The ] will be on all log lines, between the (usually) fixed length prefix and the message.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This non-standard attribute has been the cause of many problems,
so reverting back to using only the default attributes.