Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cloud-sql information #652

Merged
merged 1 commit into from
Oct 1, 2018
Merged

Conversation

wtgee
Copy link
Member

@wtgee wtgee commented Oct 1, 2018

  • Some of this will move over to the panoptes/panoptes-network repo.

* Some of this will probably move over to the panoptes/panoptes-network
repo.
@wtgee wtgee added the Quick PR This PR should be quick to review. label Oct 1, 2018
@wtgee wtgee requested a review from jamessynge October 1, 2018 00:32
@wtgee wtgee mentioned this pull request Oct 1, 2018
13 tasks
@codecov
Copy link

codecov bot commented Oct 1, 2018

Codecov Report

Merging #652 into develop will increase coverage by 0.72%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #652      +/-   ##
===========================================
+ Coverage    69.19%   69.92%   +0.72%     
===========================================
  Files           65       64       -1     
  Lines         5704     5639      -65     
  Branches       799      794       -5     
===========================================
- Hits          3947     3943       -4     
+ Misses        1548     1486      -62     
- Partials       209      210       +1
Impacted Files Coverage Δ
pocs/serial_handlers/protocol_arduinosimulator.py 75.67% <0%> (-1.16%) ⬇️
pocs/observatory.py 88.17% <0%> (-0.34%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77cd582...ea44b14. Read the comment docs.

@jamessynge
Copy link
Contributor

Any idea why pocs/serial_handlers/protocol_arduinosimulator.py would show a drop in coverage from this change?

@wtgee
Copy link
Member Author

wtgee commented Oct 1, 2018

Any idea why pocs/serial_handlers/protocol_arduinosimulator.py would show a drop in coverage from this change?

It shows up in every coverage report. This is what I have been trying to figure out. #653

@wtgee wtgee merged commit 3df9aa7 into panoptes:develop Oct 1, 2018
@wtgee wtgee deleted the remove-cloud-sql-db branch October 1, 2018 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Quick PR This PR should be quick to review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants