-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing tests related to image solving with simulator #627
Conversation
* Use unsolved image so we can test solving * Pass `skip_solved=False` during `analyze_recent`. Helps with testing when the same image is used repeatedly, shouldn't affect normal usage. * Add some extra logging
Codecov Report
@@ Coverage Diff @@
## develop #627 +/- ##
===========================================
- Coverage 67.22% 67.19% -0.03%
===========================================
Files 65 65
Lines 5690 5692 +2
Branches 798 798
===========================================
Hits 3825 3825
- Misses 1655 1656 +1
- Partials 210 211 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes look fine to me, so if it's solving the problem it was intended to solve LGTM.
An aside on the image solving, we noticed during the recent testing with Huntsman that if given ludicrously large images the solving will timeout. We saw this consistently when one of the 50 Mpixel FLI ML50100 cameras was enabled, which due to its name would become the default primary imager. We got a warning in the log about analysis failing due to solving timing out for every image we took. |
There is a But we should probably figure out if the solving can be done asynchronously (and/or if needed at all for Huntsman observing). |
I suspected that there was a parameter for this somewhere.
Definitely. The processing that goes on at the end of each science exposure can take quite a while. It's not a huge issue for 5+ minute long galaxy exposures but it is contributing to some substantial gaps in temporal coverage when trying bright star transits. Should look at deferring as much as possible to after the next exposure has started. |
skip_solved=False
duringanalyze_recent
. Helps with testing whenthe same image is used repeatedly, shouldn't affect normal usage.