Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use unit_id for sequence and image ids #613

Merged
merged 4 commits into from
Sep 21, 2018

Conversation

wtgee
Copy link
Member

@wtgee wtgee commented Sep 20, 2018

  • Behavior Change Enables pan_id in the config by default. PAN000 as simulator?

Closes #586

* **Behavior Change** Enables `pan_id` in the config by default. `PAN000` as simulator?

Closes panoptes#586
@wtgee wtgee requested a review from jamessynge September 20, 2018 08:54
@wtgee wtgee added the bug label Sep 20, 2018
@@ -1,6 +1,6 @@
---
name: Generic PANOPTES Unit
# pan_id: PANxyz # This unit's assigned identifier.
pan_id: PAN000 # This unit's assigned identifier.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... PAN000 is a "fake" id that no unit uses.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I greatly expanded this.

@wtgee wtgee merged commit 0ee3024 into panoptes:develop Sep 21, 2018
@wtgee wtgee deleted the fix-sequence-and-image-ids-586 branch September 21, 2018 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants