Use topic terminology from ZeroMQ #605
Conversation
We were using both channel and msg_type to refer to what ZeroMQ calls topics. No need for three terms, so this changes them all to topic.
| Messages are sent to channels, a name that can be used to allow | ||
| a high-level partitioning of messages. A channel name may not | ||
| include whitespace. Among the currently used channel names are: | ||
| Messages are sent to topics, a name that can be used to allow |
There was a problem hiding this comment.
Is this the best place to record all the current topics?
There was a problem hiding this comment.
My plan is to develop a scheme for future topics and to also write general documentation about topics and filtering. I've created issue #606 for that.
|
|
||
| * TEST-CHANNEL (test_messaging.py) | ||
| * Test-Topic (test_messaging.py) |
There was a problem hiding this comment.
Seems like we now have a mix of naming conventions. I know they are all allowed but should we have some logical scheme?
There was a problem hiding this comment.
That change was deliberate, just to test that the title-case form was supported.
| # Channel names must consist of the characters. | ||
| name_re = re.compile('[a-zA-Z][-a-zA-Z0-9_.:]*') | ||
| # Topic names must consist of the characters. | ||
| topic_name_re = re.compile('[a-zA-Z][-a-zA-Z0-9_.:]*') |
There was a problem hiding this comment.
Don't need the r' with re.compile?
There was a problem hiding this comment.
Raw strings are only needed when the string includes characters to be escaped AND you don't want to double escape them... or multi-line strings.
pocs/utils/messaging.py
Outdated
| """ Create a listener | ||
|
|
||
| Args: | ||
| port (int): The port (on localhost) to bind to. | ||
| channel (str): Which topic channel to subscribe to. | ||
| topic (str): Which topic topic to subscribe to. |
We were using both channel and msg_type to refer to what ZeroMQ
calls topics. No need for three terms, so this changes them
all to topic.
Fixes #597.