Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a config file for test_codestyle.py #594

Merged
merged 1 commit into from
Sep 15, 2018

Conversation

jamessynge
Copy link
Contributor

pycodestyle supports reading config options from a file.
This change adds such a file and modifies test_codestyle.py
to reference it.

Removes ignoring of E402 (module level import not at top of file)
because we don't violate it now.

Sets the line length to 99, but continues to ignore E501 (line
too long) because we have a lot of those.

pycodestyle supports reading config options from a file.
This change adds such a file and modifies test_codestyle.py
to reference it.

Removes ignoring of E402 (module level import not at top of file)
because we don't violate it now.

Sets the line length to 99, but continues to ignore E501 (line
too long) because we have a lot of those.
Copy link
Member

@wtgee wtgee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm curious to see if this is different than the linting that I use with my editor, which doesn't use pyflakes.

But definitely happy to have this in. Thanks!

@wtgee wtgee merged commit 3358d3f into panoptes:develop Sep 15, 2018
@jamessynge jamessynge deleted the codestyle branch October 13, 2018 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants