Ensure that channel names don't have spaces #593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Throws an exception if a channel name doesn't match a regular expression, one which doesn't include spaces. Fixes issue panoptes#205. Greatly expand the class level documentation in PanMessaging. Enforce that the value of a message is either a string or a dict (that was already effectively required, but now the failure message will be clear).
wtgee
approved these changes
Sep 15, 2018
|
|
||
| * PANCHAT (sent from POCS.say) | ||
| * PAWS-CMD (sent from PAWS websockets.py) | ||
| * POCS (sent by class POCS) |
There was a problem hiding this comment.
I don't recall what this is used for.
| * RUNNING (test_pocs.py) | ||
| * POCS-CMD (test_pocs.py) | ||
|
|
||
| The method receive_message will return messages from all channels; |
There was a problem hiding this comment.
While this is true, the intended usage is to pass the channel to the create_subcriber and then no filtering is needed by the user. This should be the recommended behaviour.
There was a problem hiding this comment.
AFTER this PR, we should consider using the name topic instead of channel or msg_type, which is the term used by zeromq. It'll make it easier for developers that are trying to understand this subsystem.
|
|
||
| Note: PAWS doesn't use PanMessaging, which will likely result in | ||
| problems as we evolve PanMessaging and the set of channels. | ||
| TODO: Figure out how to share PanMessaging with PAWS. |
There was a problem hiding this comment.
I think the answer is that we will be changing PAWS.
| @@ -188,13 +259,13 @@ def scrub_message(self, message): | |||
| if isinstance(v, Time): | |||
| v = str(v.isot).split('.')[0].replace('T', ' ') | |||
|
|
|||
| # Hmmmm | |||
| # Hmmmm. What is going on here? We need some documentation. | |||
There was a problem hiding this comment.
Yup. I can't remember what case this was handling. I'll try to find out.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Throws an exception if a channel name doesn't match
a regular expression, one which doesn't include spaces.
Fixes issue #205.
Enforce that the value of a message is either a string
or a dict (that was already effectively required, but
now the failure message will be clear).
Greatly expand the class level documentation in PanMessaging.