-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix install-dependencies.sh for Ubuntu 18.04 #585
Merged
jamessynge
merged 14 commits into
panoptes:develop
from
jamessynge:tidy-install-dependencies
Sep 14, 2018
Merged
Changes from 7 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
ea5b3c9
Improve install-dependencies.sh
jamessynge 7ae70d5
Only download, build and install astrometry if necessary
jamessynge 6207cf4
Warn user when the profile or conda has changed
jamessynge aa2d84d
Fix up final message
jamessynge 3ad92ba
Workaround conda being a non-exported shell function
jamessynge 1a52666
Take a different approach to detecting conda changes
jamessynge aee048a
Fix typo
jamessynge ee21f43
WIP
jamessynge 61d8005
Change method of hooking into user's shell
jamessynge 93dc8d6
Remove support for building cfitsio from scratch
jamessynge 5665796
Fix how conda is found
jamessynge 68da834
Fix typo in generate script
jamessynge 5747cd3
Escape $PANDIR so that we use the variable's value when
jamessynge 18126b5
Combine recommended commands on one line
jamessynge File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, I've wondered if we should skip git and just install the zip. An idea for later if we are finding we want to force atomic updates or something like that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, an interesting idea. The downside is that it makes it harder to keep track of what is installed.