Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mongodb install to support Ubuntu 18.04 #583

Merged
merged 1 commit into from
Sep 8, 2018

Conversation

jamessynge
Copy link
Contributor

This is extracted from #578.

@jamessynge jamessynge requested a review from a team September 8, 2018 18:03
@codecov
Copy link

codecov bot commented Sep 8, 2018

Codecov Report

Merging #583 into develop will increase coverage by 0.12%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           develop    #583      +/-   ##
==========================================
+ Coverage    70.38%   70.5%   +0.12%     
==========================================
  Files           64      64              
  Lines         5520    5520              
  Branches       769     769              
==========================================
+ Hits          3885    3892       +7     
+ Misses        1426    1422       -4     
+ Partials       209     206       -3
Impacted Files Coverage Δ
pocs/observatory.py 85.75% <0%> (+0.59%) ⬆️
pocs/serial_handlers/protocol_arduinosimulator.py 77.3% <0%> (+1.92%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2df8b5b...5f663bc. Read the comment docs.

Copy link
Member

@wtgee wtgee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I wonder if we should worry about authorization/authentication on the mongodb. If so we might want to set that up here, but could be in a separate PR.

@jamessynge
Copy link
Contributor Author

Yes, we should definitely worry about it. I just haven't given it enough thought yet.

@jamessynge jamessynge merged commit bb7a578 into panoptes:develop Sep 8, 2018
@jamessynge jamessynge deleted the update-mongodb-install branch September 9, 2018 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants