Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating install scripts for Ubuntu 18.04 - WIP #578

Closed
wants to merge 5 commits into from
Closed
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 11 additions & 23 deletions requirements.txt
Original file line number Diff line number Diff line change
@@ -1,26 +1,14 @@
astroplan
astropy >= 3.0.0
ccdproc
codecov
coveralls
dateparser
# These are packages that are NOT available via our
# choice of conda repositories; there are less well
# known repositories that do offer them, but that is
# more of a security risk.

# Python wrapper for ffmpeg.
ffmpy
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could probably lose the option. It is just a thin wrapper around ffmpeg. Since we don't have many varying options it would be trivial to write our own script.

gcloud
google-cloud-storage
matplotlib >= 2.0.0

# Mock object support for Python testing.
mocket
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could potentially work around this. Since we have requests elsewhere now it might be cleaner to switch TheSkyX calls to requests and then use some of the mock tools provided for it, which are available.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm trying to keep changes in this PR to a minimum (i.e. it will be large enough as is). I'd like to focus on just the switch to conda and 18.04. In fact, maybe I already shoved to much into this, and should extract the 18.04 (Mongodb) changes. Sigh. Lots of slow tests required.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, don't want to do it for this PR, mostly just commenting on what I think we could eventually get rid of.

numpy >= 1.12.1
pycodestyle == 2.3.1
pymongo >= 3.2.2
pyserial >= 3.1.1
pytest >= 3.4.0
python_dateutil >= 2.5.3
PyYAML >= 3.11
pyzmq >= 15.3.0
readline
requests
scikit_image >= 0.12.3
scipy >= 0.17.1

# State machine library for Python.
transitions >= 0.4.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And technically I'm still a maintainer on this project though I haven't done anything for years. 😕 I can find out if there is any plan.

tweepy
wcsaxes

6 changes: 5 additions & 1 deletion scripts/install/apt-packages-list.txt
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ libbz2-dev
libcfitsio-dev
libjpeg-dev
libnetpbm10-dev
libpng12-dev
libpng-dev
netpbm
python-dev
python-numpy
Expand Down Expand Up @@ -68,3 +68,7 @@ ffmpeg

# Used for colorizing log files.
grc

# https://jupyter.org/
jupyter-notebook

31 changes: 31 additions & 0 deletions scripts/install/conda-packages-list.txt
Original file line number Diff line number Diff line change
@@ -1,2 +1,33 @@
astroplan
astropy >= 3.0.0
ccdproc
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even though conda fixes the problems with this (via astroscrappy), we are not actually using it anywhere in the repo. Might as well just remove.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove ccdproc?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think so. It will come through in PIAA probably anyway but might as well get rid of it here since it's not an actual dependency.

codecov
coveralls
cython
dateparser
google-cloud-sdk
google-cloud-storage
matplotlib >= 2.0.0
numpy >= 1.12.1
pycodestyle == 2.3.1
pymongo >= 3.2.2
pyserial >= 3.1.1
pytest >= 3.4.0
pandas
python
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this actually install the python version from here and if so should we specify a version?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Specifying a version is problematic. If you say ==3.7, then the constraints are unsolvable.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gotcha.

python-dateutil >= 2.5.3
PyYAML >= 3.11
pyzmq >= 15.3.0
readline
requests
scikit-image >= 0.12.3
scipy >= 0.17.1

# Jupyter-notebook requires Tornado versions between 4 and 5. See:
# https://stackoverflow.com/questions/49141525/install-jupyter-notebook-on-miniconda
# https://github.com/ipython/ipython/issues/8249
# https://github.com/jupyter/help/issues/324

tornado == 4.5.3
tweepy
wcsaxes
Loading