-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Coverage calculation accounting for concurrency #566
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #566 +/- ##
==========================================
+ Coverage 70.44% 70.55% +0.1%
==========================================
Files 64 64
Lines 5518 5518
Branches 767 767
==========================================
+ Hits 3887 3893 +6
+ Misses 1425 1420 -5
+ Partials 206 205 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but was almost expecting a huge jump in coverage. :) Will be nice to be more accurate. Will leave for @jamessynge to see if he has comments.
@wtgee It would make more difference if |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have an opinion yet as to how well it works, but would like to try!
I am surprised that we don't see more of a jump, but I'll take a look once merged and I can try it on my laptop.
I'm looking forward to trying this out, and hopefully getting some improved coverage. |
While working on #547 I ran into problems with inaccurate test coverage reports because the existing
coverage
and Travis CI configurations produced results which did not take into account concurrency, in particular scripts started withsubprocess
. I was able to come up with some changes to the configurations that appear to resolve these problems, and should properly calculate test coverage involvingmultiprocessing
,threading
andsubprocess
concurrency. At @wtgee's suggestion I have split these config changes out into a Pull Request of their own.