Default to rereading the fields file #488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #488 +/- ##
===========================================
- Coverage 70.48% 67.83% -2.66%
===========================================
Files 62 62
Lines 5418 5419 +1
Branches 751 752 +1
===========================================
- Hits 3819 3676 -143
- Misses 1392 1544 +152
+ Partials 207 199 -8
Continue to review full report at Codecov.
|
jamessynge
approved these changes
Feb 16, 2018
| @@ -30,6 +30,8 @@ def get_observation(self, time=None, show_all=False, reread_fields_file=False): | |||
| defaults to time called | |||
| show_all (bool, optional): Return all valid observations along with | |||
| merit value, defaults to False to only get top value | |||
| reread_fields_file (bool, optional): If the fields file should be reread | |||
There was a problem hiding this comment.
And the reason for not making the change here in the params list (i.e. default =True).
|
@jamessynge I changed this to a config option, which fixed the tests (coverage went down 2.5% the other way). Let me know what you think of this setup. Thanks. |
…lt-reread-fields
and print a message. This is necessary for when just the priority (or other attribute) of an observation is changed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's annoying and inconvenient to have to shut down POCS just to read new targets. This changes the default to always reread the target file before scheduling from the
schedulingstate.Closes #344