Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup inconsistency in take_exposure call #457

Merged
merged 1 commit into from
Feb 8, 2018

Conversation

wtgee
Copy link
Member

@wtgee wtgee commented Feb 8, 2018

The base method and sbig expect *args, **kwargs. Warning messages were appearing in the tests for the simulator.

@AnthonyHorton I'm tagging you because you cleaned up the code so are more familiar with what would be the expected behaviour. Seems fine to just add the extra args to me.

The base method and sbig expect `*args, **kwargs`. Warning messages
were appearing in the tests for the simulator
@wtgee wtgee requested a review from AnthonyHorton February 8, 2018 02:39
@codecov
Copy link

codecov bot commented Feb 8, 2018

Codecov Report

Merging #457 into develop will increase coverage by 0.13%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #457      +/-   ##
===========================================
+ Coverage     67.4%   67.53%   +0.13%     
===========================================
  Files           63       63              
  Lines         5289     5289              
  Branches       738      738              
===========================================
+ Hits          3565     3572       +7     
+ Misses        1525     1516       -9     
- Partials       199      201       +2
Impacted Files Coverage Δ
pocs/camera/simulator.py 100% <100%> (ø) ⬆️
pocs/state/machine.py 88.27% <0%> (-0.69%) ⬇️
pocs/serial_handlers/protocol_arduinosimulator.py 74.8% <0%> (-0.39%) ⬇️
pocs/observatory.py 71.7% <0%> (-0.28%) ⬇️
pocs/state/states/default/pointing.py 75.51% <0%> (+20.4%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c3d2fb...5c20e2d. Read the comment docs.

Copy link
Collaborator

@AnthonyHorton AnthonyHorton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@wtgee wtgee merged commit f64f2be into panoptes:develop Feb 8, 2018
@wtgee wtgee deleted the cleanup-exposure-inconsistency branch August 20, 2022 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants