Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating upload script #401

Merged
merged 3 commits into from
Jan 21, 2018
Merged

Conversation

wtgee
Copy link
Member

@wtgee wtgee commented Jan 21, 2018

  • Use PAN_ID
  • Fixes dates
  • Better automated options

For now this is just used manually via the command line. After merge the next step would be to integrate into the housekeeping state.

Note that this is being used successfully on PAN001

@wtgee wtgee requested a review from a team January 21, 2018 00:19
@codecov
Copy link

codecov bot commented Jan 21, 2018

Codecov Report

Merging #401 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #401   +/-   ##
========================================
  Coverage    69.05%   69.05%           
========================================
  Files           60       60           
  Lines         4740     4740           
  Branches       653      653           
========================================
  Hits          3273     3273           
  Misses        1293     1293           
  Partials       174      174

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad6115c...8b33774. Read the comment docs.

Copy link
Contributor

@jamessynge jamessynge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'll let you know how it goes when I try it out.

@jamessynge jamessynge merged commit 4e247d9 into panoptes:develop Jan 21, 2018
@wtgee wtgee mentioned this pull request Jan 24, 2018
@wtgee wtgee deleted the use-gcloud-for-upload branch August 20, 2022 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants