Tracking Updates #355
Tracking Updates #355
Conversation
* Wait for the Dec axis to move before moving RA axis * Only update tracking if > 50ms correction * Some long line clean up Note: Most of this `update_tracking` code should move into the mount class and accept `current_offset_info` as a param
Codecov Report
@@ Coverage Diff @@
## develop #355 +/- ##
===========================================
+ Coverage 82.97% 83.11% +0.14%
===========================================
Files 51 51
Lines 3441 3452 +11
Branches 438 442 +4
===========================================
+ Hits 2855 2869 +14
+ Misses 441 432 -9
- Partials 145 151 +6
Continue to review full report at Codecov.
|
| @@ -148,12 +149,15 @@ def status(self): | |||
| status['observation']['field_ha'] = self.observer.target_hour_angle( | |||
| t, self.current_observation.field) | |||
|
|
|||
| evening_astro_time = self.observer.twilight_evening_astronomical(t, which='next') | |||
There was a problem hiding this comment.
What does next produce if at midnight? Tomorrow night?
There was a problem hiding this comment.
Correct. The default is nearest, which would go backwards. With next we always get the upcoming.
| @@ -316,36 +320,48 @@ def update_tracking(self): | |||
| else: | |||
| ra_direction = 'east' | |||
|
|
|||
There was a problem hiding this comment.
Could you add some more explanation to the docstring, for those of us who are ignorant of mounts. For example, what does 50 milliseconds measure here? An angle? A time?
There was a problem hiding this comment.
Done. I'm going to merge but let me know if docstring doesn't make sense. I'd like to test these additions on PAN001 tonight.
Note: Most of this
update_trackingcode should move into the mountclass and accept
current_offset_infoas a paramCorrects for small adjustments as reported in #351
Relates to #350