Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Equinox fixes #346

Merged
merged 1 commit into from
Jan 15, 2018
Merged

Equinox fixes #346

merged 1 commit into from
Jan 15, 2018

Conversation

wtgee
Copy link
Member

@wtgee wtgee commented Jan 15, 2018

I'm not sure why this is giving me such problems. Sometimes it is coming
through as a string, sometimes as a Time object. Handle it better
in the status method here although really should trace down when/how/what
it is getting set to.

Small fix for say

I'm not sure why this is giving me such problems. Sometimes it is coming
through as a string, sometimes as a `Time` object. Handle it better
in the status method here although really should trace down when/how/what
it is getting set to.

Small fix for `say`
@wtgee wtgee requested a review from jamessynge January 15, 2018 06:07
@codecov
Copy link

codecov bot commented Jan 15, 2018

Codecov Report

Merging #346 into develop will increase coverage by 0.08%.
The diff coverage is 28.57%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #346      +/-   ##
===========================================
+ Coverage    83.05%   83.14%   +0.08%     
===========================================
  Files           51       51              
  Lines         3435     3441       +6     
  Branches       437      438       +1     
===========================================
+ Hits          2853     2861       +8     
+ Misses         437      436       -1     
+ Partials       145      144       -1
Impacted Files Coverage Δ
pocs/state/states/default/pointing.py 87.75% <0%> (ø) ⬆️
pocs/scheduler/observation.py 93.44% <33.33%> (-6.56%) ⬇️
pocs/observatory.py 84.84% <0%> (-0.31%) ⬇️
pocs/dome/astrohaven.py 72.38% <0%> (+1.9%) ⬆️
pocs/dome/protocol_astrohaven_simulator.py 79.74% <0%> (+2.1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b00a137...964db29. Read the comment docs.

@jamessynge jamessynge merged commit 49f3ffc into panoptes:develop Jan 15, 2018
@wtgee wtgee mentioned this pull request Jan 24, 2018
@wtgee wtgee deleted the equinox-woes branch August 20, 2022 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants