Only the primary camera should have images saved in list #329
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #329 +/- ##
===========================================
+ Coverage 83.81% 83.84% +0.03%
===========================================
Files 51 51
Lines 3367 3368 +1
Branches 422 422
===========================================
+ Hits 2822 2824 +2
Misses 404 404
+ Partials 141 140 -1
Continue to review full report at Codecov.
|
| @@ -143,7 +143,8 @@ def take_observation(self, observation, headers=None, filename=None, **kwargs): | |||
| proc = self.take_exposure(seconds=exp_time, filename=file_path) | |||
|
|
|||
| # Add most recent exposure to list | |||
| observation.exposure_list[image_id] = file_path.replace('.cr2', '.fits') | |||
| if self.is_primary: | |||
| observation.exposure_list[image_id] = file_path.replace('.cr2', '.fits') | |||
There was a problem hiding this comment.
Is the point that we're trying to have a single canonical image to represent each exposure, even if we have multiple cameras? I'm not sure I understand why. Perhaps a comment?
There was a problem hiding this comment.
The exposure list is used for tracking purposes so the closed-loop compares the pointing image to the last_exposure. We always want to compare just the primary camera to itself.
I was going to expand exposure_list so it contained all exposures, which would make the cleanup and uploading to cloud a bit easier. So this might change going forward.
I'll add an explanation.
There was a problem hiding this comment.
I took the easy out and made #342 for now. I want to make the whole thing more robust.
The
expsoure_listis used to get thelast_exposure, which is then used for pointing comparisons. We only want to track the primary camera for this.