Move CharBuffer class into its own file so it can be shared by #300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
power_board and telemetry_board sketches.
wtgee
approved these changes
Jan 5, 2018
| uint8_t len = 0; | ||
| while (!Empty() && isdigit(Peek())) { | ||
| char c = Next(); | ||
| v = v * 10 + c - '0'; |
There was a problem hiding this comment.
What's actually going on here? I can't seem to parse it.
Codecov Report
@@ Coverage Diff @@
## develop #300 +/- ##
========================================
Coverage 83.84% 83.84%
========================================
Files 51 51
Lines 3367 3367
Branches 422 422
========================================
Hits 2823 2823
Misses 404 404
Partials 140 140Continue to review full report at Codecov.
|
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
power_board and telemetry_board sketches.