Mock TheSkyX #287
Merged
Mock TheSkyX #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use [Mocket](https://github.com/mindflayer/python-mocket) to create a fake socket connection. * A real connection is used once with `--with-hardware theskyx` and the responses are recorded into a json file. Subsequent tests then use the json file to mock the responses * Improve errors for TheSkyX
Codecov Report
@@ Coverage Diff @@
## develop #287 +/- ##
===========================================
+ Coverage 80.66% 81.28% +0.61%
===========================================
Files 46 46
Lines 3207 3227 +20
Branches 411 412 +1
===========================================
+ Hits 2587 2623 +36
+ Misses 474 457 -17
- Partials 146 147 +1
Continue to review full report at Codecov.
|
jamessynge
approved these changes
Jan 2, 2018
Couldn't get timeout to work with Mocket although does work with actual copy of TheSkyX. Removed timeout test but left exception class
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--with-hardware theskyxandthe responses are recorded into a json file. Subsequent tests then
use the json file to mock the responses