Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move polar alignment helper functions into POCS images utils #265

Merged
merged 1 commit into from
Dec 29, 2017

Conversation

wtgee
Copy link
Member

@wtgee wtgee commented Dec 29, 2017

The polar alignment features aren't used in PIAA, they are only used in pocs_shell, so this is more appropriate.

However, this was mainly done because of the order in which some of the new files were loaded, causing the logger to emit before the new log adapter (from #254) can be loaded. By loading from pocs/utils/images.py that loading ordering is fixed. Closes #263 and #264.

@wtgee wtgee requested a review from jamessynge December 29, 2017 03:46
@codecov
Copy link

codecov bot commented Dec 29, 2017

Codecov Report

Merging #265 into develop will decrease coverage by 0.69%.
The diff coverage is 27.9%.

Impacted file tree graph

@@            Coverage Diff             @@
##           develop     #265     +/-   ##
==========================================
- Coverage    79.72%   79.02%   -0.7%     
==========================================
  Files           46       46             
  Lines         3235     3275     +40     
  Branches       425      426      +1     
==========================================
+ Hits          2579     2588      +9     
- Misses         509      540     +31     
  Partials       147      147
Impacted Files Coverage Δ
pocs/utils/images.py 46.15% <27.9%> (-2.93%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3cf2831...37dca48. Read the comment docs.

Copy link
Contributor

@jamessynge jamessynge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this will help.

@jamessynge jamessynge merged commit 11927ca into panoptes:develop Dec 29, 2017
@wtgee wtgee mentioned this pull request Dec 29, 2017
@wtgee wtgee mentioned this pull request Jan 2, 2018
@wtgee wtgee deleted the move-polar-alignment branch August 20, 2022 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

peas_shell fails to load_weather
2 participants