Fix timing of command responses from Astrohaven simulator. #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Was emitting response too soon, so driver was skipping past it when looking for a response, thus never detected that the desired state had in fact been reached. Added logging to the Astrohaven simulator to help with future debugging.
Codecov Report
@@ Coverage Diff @@
## develop #243 +/- ##
===========================================
- Coverage 79.87% 79.82% -0.05%
===========================================
Files 42 42
Lines 3185 3197 +12
Branches 413 412 -1
===========================================
+ Hits 2544 2552 +8
- Misses 501 503 +2
- Partials 140 142 +2
Continue to review full report at Codecov.
|
wtgee
approved these changes
Dec 23, 2017
| if remaining <= 0: | ||
| self.do_output() | ||
| self.update_next_output_time() | ||
| continue | ||
| # Maybe a short delay here? |
There was a problem hiding this comment.
This comment was here before but is it referring to same thing as short delay added on 132?
There was a problem hiding this comment.
Doh, should have fixed that. Will do so now.
Add clarifying comments about placement of sleep and drain (discard) operations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was emitting response too soon, so driver was skipping past it when
looking for a response, thus never detected that the desired state had
in fact been reached.
Added logging to the Astrohaven simulator to help with future debugging.
Fixes #240