Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

State Machine Updates #219

Merged
merged 3 commits into from
Dec 19, 2017
Merged

State Machine Updates #219

merged 3 commits into from
Dec 19, 2017

Conversation

wtgee
Copy link
Member

@wtgee wtgee commented Dec 19, 2017

  • Allow an absolute path to be passed for state machine

@wtgee
State Machine Updates
f53802e 
* Allow an absolute path to be passed for state machine
@wtgee wtgee requested review from a team December 19, 2017 06:41
@codecov
Copy link

codecov bot commented Dec 19, 2017 •
edited
Loading

Codecov Report

Merging #219 into develop will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #219      +/-   ##
===========================================
+ Coverage    80.15%   80.17%   +0.01%     
===========================================
  Files           42       42              
  Lines         3145     3147       +2     
  Branches       405      406       +1     
===========================================
+ Hits          2521     2523       +2     
  Misses         491      491              
  Partials       133      133
Impacted Files Coverage Δ
pocs/state/machine.py 88.73% <100%> (+0.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89ded6d...15e855c. Read the comment docs.

AnthonyHorton
AnthonyHorton approved these changes Dec 19, 2017
View reviewed changes
Copy link
Collaborator

@AnthonyHorton AnthonyHorton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

pocs/state/machine.py Outdated

Returns:
dict: Dictonary with `states` and `transitions` keys.
dict: Dictonary with `states` and `transitions` keys.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/Dictonary/Dictionary

@wtgee wtgee merged commit 4728df6 into panoptes:develop Dec 19, 2017
@wtgee wtgee deleted the state-machine-file-update branch December 19, 2017 09:36
@wtgee wtgee mentioned this pull request Dec 29, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AnthonyHorton AnthonyHorton AnthonyHorton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wtgee @AnthonyHorton