Re-use PanLogger instances if the parameters haven't changed.

[jamessynge]

Fixes #190.

[jamessynge]

It appears the build failed due to a network issue. Closing and reopening PR to trigger build again.

[codecov]

Codecov Report

Merging #192 into develop will increase coverage by 0.05%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop     #192      +/-   ##
===========================================
+ Coverage    81.27%   81.32%   +0.05%     
===========================================
  Files           37       37              
  Lines         2654     2662       +8     
  Branches       330      331       +1     
===========================================
+ Hits          2157     2165       +8     
  Misses         392      392              
  Partials       105      105

Impacted Files	Coverage Δ
pocs/utils/logger.py	96.82% <100%> (+0.46%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1537b05...7451b0b. Read the comment docs.

[wtgee]

It appears the build failed due to a network issue. Closing and reopening PR to trigger build again.

FYI, there is a Restart Build button on travis. Let me know if you don't have access to it.

[wtgee]

In PanBase there is a global that is making sure this doesn't happen, but that is only for objects that inherit from PanBase. I'm guessing that you ran into this with some of the abstract dome class, which I noticed doesn't inherit from PanBase.

I like the json solution but it seems like it would also just have the problem of creating multiple all_loggers each time it is loaded.

[jamessynge]

As long as importing works correctly, all the imports of pocs.utils.logger will reference the same one module instance, so they'll share the same global (module scope) variable all_loggers. And thus a single PanLogger is created.

[wtgee]

Let's remove the global _logger and just use this setup. It is essentially the same thing.

[jamessynge]

PTAL

[wtgee]

👍