-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge PACE #167
Merge PACE #167
Conversation
…nder wrote in June 2013.
…xpose, cancel, query), but needs query and cancel to be written.
…uino software happy.
Added Test_DSLR.py python script to send command string to Arduino.
…mit has a timing problem and the exposure times are way off.
… green led flash inside camera
* Small typo fixes
* Better reporting/switching
* Adding multipliers to get amps
Infineon Shield current sensing
Current testing with the mount hooked up to the 24v shield and the arduino uno
Fix telemetry board shutdown bug
Codecov Report
@@ Coverage Diff @@
## develop #167 +/- ##
=======================================
Coverage 80.6% 80.6%
=======================================
Files 36 36
Lines 2527 2527
Branches 319 319
=======================================
Hits 2037 2037
Misses 386 386
Partials 104 104 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't readily tell if there are any changes to these files being moved into this repo, except for their locations. Are there?
@@ -1,4 +1,6 @@ | |||
## [Unreleased] | |||
### Added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI, I'm a bit skeptical about using a file like this for tracking major changes that should be included release notes. One issue is that we'll have frequent conflicts on this file as there will be many changes at the same point in the file.
I wonder if using the github PR "labels" feature would be useful here (e.g. mark new features with FEATURE and mark notable bug fixes with BUGFIX). Thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Essentially these are the release notes.
I couldn't quite figure out what to do about the frequent conflicts either. It's an issue when there are multiple outstanding Feature PRs that you want to merge at once.
The idea is to alleviate the work on whomever is doing the release so they don't have to dig back through everything that has been changed since last release.
Definitely open to other suggestions.
There are files removed but nothing is changed. |
Merges the PACE history into POCS.
Arduino files are placed in
$POCS/resources/arduino_files
Note: Should not be squashed.