Version number updates #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
wtgee
commented
Dec 3, 2017
wtgee
commented
- Change terminology to match semantic versioning
- Don't hard-code version number in test (closes Change hard-coded version number in test_observatory #154)
* Change terminology to match semantic versioning * Don't hard-code version number in test (closes panoptes#154)
Codecov Report
@@ Coverage Diff @@
## develop #166 +/- ##
=======================================
Coverage 80.6% 80.6%
=======================================
Files 36 36
Lines 2527 2527
Branches 319 319
=======================================
Hits 2037 2037
Misses 386 386
Partials 104 104
Continue to review full report at Codecov.
|
jamessynge
reviewed
Dec 3, 2017
pocs/version.py
Outdated
| @@ -1,6 +1,6 @@ | |||
| # this file was automatically generated | |||
There was a problem hiding this comment.
Is this claim true? If so, how is it generated?
There was a problem hiding this comment.
Having now read Creating a New Release, I can see that this file manually updated, so the comment should be removed.
There was a problem hiding this comment.
Amazing how I can miss that in a file that has 5 lines total. Thanks.
jamessynge
previously approved these changes
Dec 3, 2017
jamessynge
approved these changes
Dec 4, 2017
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.