Remove support for threaded IO from rs232.SerialData #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use anyway, and we may be able to use newer features in PySerial to achieve the same result.
Codecov Report
@@ Coverage Diff @@
## develop #148 +/- ##
=======================================
Coverage 80.6% 80.6%
=======================================
Files 36 36
Lines 2527 2527
Branches 319 319
=======================================
Hits 2037 2037
Misses 386 386
Partials 104 104Continue to review full report at Codecov.
|
wtgee
previously approved these changes
Dec 1, 2017
| def __init__(self, | ||
| port=None, | ||
| baudrate=115200, | ||
| threaded=None, |
There was a problem hiding this comment.
I'm temped to say we should just add a *args, **kwargs and remove the threaded=None.
There was a problem hiding this comment.
I'd prefer to rip out the param as soon as the PACE code is merged in here, as that way we don't accidentally accept bogus params.
|
Merged in develop. Please review once travis is done, and merge into develop if OK. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It wasn't in use, complicates testing, and we may be able
to use newer features in PySerial toachieve the same result.