Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove custom gphoto2 install #1278

Merged
merged 1 commit into from
Oct 2, 2024
Merged

Conversation

wtgee
Copy link
Member

@wtgee wtgee commented Oct 2, 2024

This pull request includes changes to the scripts/install/install-pocs.sh script to update the installation process by modifying system dependencies and removing redundant installation steps.

Updates to system dependencies and installation steps:

  • scripts/install/install-pocs.sh: Added gphoto2 to the list of system dependencies in the system_deps function.
  • scripts/install/install-pocs.sh: Removed the install_gphoto2 and write_udev_entries steps from the do_install function, as they are no longer needed. The write_udev_entries will happen as part of pocs mount setup.

* Install from apt, which is at the current version. This should save a lot of time compared to the compiling needed for the custom install.
@wtgee wtgee self-assigned this Oct 2, 2024
Copy link

codecov bot commented Oct 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.89%. Comparing base (f7f1206) to head (5b3efcc).
Report is 7 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1278   +/-   ##
========================================
  Coverage    70.89%   70.89%           
========================================
  Files          100      100           
  Lines         8487     8487           
  Branches      1174     1174           
========================================
  Hits          6017     6017           
  Misses        2319     2319           
  Partials       151      151           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wtgee wtgee merged commit f2e52c0 into develop Oct 2, 2024
7 checks passed
@wtgee wtgee deleted the remove-custom-gphoto2-install branch October 2, 2024 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant