Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fastapi deprecation 1208 #1276

Merged
merged 16 commits into from
May 24, 2024
Merged

Fastapi deprecation 1208 #1276

merged 16 commits into from
May 24, 2024

Conversation

wtgee
Copy link
Member

@wtgee wtgee commented May 24, 2024

Update the services using FastAPI (power, weather) to properly use lifespan events instead of the deprecated startup/shutdown events. This was originally in #1208 but got clobbered.

This also adds host info to the weather cli for remote weather reading.

Tested on PAN015

@wtgee wtgee self-assigned this May 24, 2024
Copy link

codecov bot commented May 24, 2024

Codecov Report

Attention: Patch coverage is 17.46032% with 52 lines in your changes are missing coverage. Please review.

Project coverage is 71.05%. Comparing base (9a0dadc) to head (d49e0fc).

Current head d49e0fc differs from pull request most recent head 1148d1d

Please upload reports for the commit 1148d1d to get more accurate results.

Files Patch % Lines
src/panoptes/pocs/utils/service/weather.py 0.00% 32 Missing ⚠️
src/panoptes/pocs/utils/service/power.py 33.33% 12 Missing ⚠️
src/panoptes/pocs/sensor/power.py 38.46% 8 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1276      +/-   ##
===========================================
- Coverage    71.31%   71.05%   -0.26%     
===========================================
  Files          100      100              
  Lines         8439     8468      +29     
  Branches      1174     1173       -1     
===========================================
- Hits          6018     6017       -1     
- Misses        2270     2300      +30     
  Partials       151      151              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wtgee wtgee merged commit 4ab8d1f into develop May 24, 2024
5 checks passed
@wtgee wtgee deleted the fastapi-deprecation-1208 branch May 24, 2024 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant