Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pretty image changes #1273

Merged
merged 2 commits into from
May 19, 2024
Merged

Pretty image changes #1273

merged 2 commits into from
May 19, 2024

Conversation

wtgee
Copy link
Member

@wtgee wtgee commented May 19, 2024

  • Fix the pretty image upload and creation to happen inline with the process_observation.
  • Upload the FITS before worrying about the pretty image.
  • Don't create network service
  • Don't create a process within the process
  • Check generic upload status.

* Don't create network service
* Don't create a process within the process
* Check generic upload status.
@wtgee wtgee self-assigned this May 19, 2024
@wtgee wtgee merged commit f9326b1 into develop May 19, 2024
5 checks passed
@wtgee wtgee deleted the remove-image-uploader branch May 19, 2024 03:41
Copy link

codecov bot commented Aug 17, 2024

Codecov Report

Attention: Patch coverage is 5.55556% with 17 lines in your changes missing coverage. Please review.

Project coverage is 71.25%. Comparing base (86f0662) to head (15a65f0).
Report is 10 commits behind head on develop.

Files Patch % Lines
src/panoptes/pocs/observatory.py 5.55% 17 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1273      +/-   ##
===========================================
+ Coverage    71.11%   71.25%   +0.14%     
===========================================
  Files          100      100              
  Lines         8468     8448      -20     
  Branches      1181     1176       -5     
===========================================
- Hits          6022     6020       -2     
+ Misses        2295     2277      -18     
  Partials       151      151              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant