Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding exceptions around image solving #112

Merged
merged 1 commit into from
Nov 12, 2017
Merged

Adding exceptions around image solving #112

merged 1 commit into from
Nov 12, 2017

Conversation

wtgee
Copy link
Member

@wtgee wtgee commented Nov 12, 2017

This catches the thrown exception but doesn't deal with a hanging subprocess. Was having troubles locating where that was coming from as all the current subprocess should have timeouts that handle them.

Closes #111

@wtgee wtgee requested a review from jamessynge November 12, 2017 06:08
@codecov
Copy link

codecov bot commented Nov 12, 2017

Codecov Report

Merging #112 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #112   +/-   ##
========================================
  Coverage    84.39%   84.39%           
========================================
  Files           35       35           
  Lines         2345     2345           
  Branches       281      281           
========================================
  Hits          1979     1979           
  Misses         285      285           
  Partials        81       81

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad3d6ff...e9249b9. Read the comment docs.

@jamessynge
Copy link
Contributor

Approved, but does this really solve #111?

@jamessynge jamessynge merged commit 279b7d1 into panoptes:develop Nov 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants