Silence missing filter name warning for dark observations #1072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danjampro
changed the title
Codecov Report
@@ Coverage Diff @@
## develop #1072 +/- ##
===========================================
+ Coverage 84.76% 84.79% +0.03%
===========================================
Files 77 77
Lines 6531 6532 +1
Branches 560 561 +1
===========================================
+ Hits 5536 5539 +3
+ Misses 836 834 -2
Partials 159 159
Continue to review full report at Codecov.
|
|
@danjampro I still think it might be a good time to bring the Any reason we couldn't move most of this PR here? AstroHuntsman/huntsman-pocs#332 |
wtgee
added a commit
that referenced
this pull request
Jan 31, 2021
Following changes in `panoptes-utils`, this cleans up and simplifies the Docker services. ## Description * **Breaking change** Python 3.8 * **Breaking change** Default service install does not include ``focuser`` dependencies. * **Breaking change** Default Docker command is a ``ipython`` console with the simulators loaded. * **Breaking change** Docker image only contains limited set of files. * **Breaking change** Directories inside the service image have been simplified for easier mapping onto desired targets on the host. The main top-level directory (i.e. ``$PANDIR``) is now ``/POCS`` with other folders nested underneath. * **Breaking change** Removing ``peas`` scripts. * Simple example script for creating a ``POCS`` instance with all simulators. * Using ``threading.excepthook`` to log errors in camera exposure threads. Addresses some of #1047. * Updated install script (includes ZSH again). * Pointing state is skipped if `num_pointing_images==0`. * Images use ``gcr.io/panoptes-exp/panoptes-utils`` as base. * Docker files are all contained within ``docker`` folder. * Docker image has tycho2 10-19 index files for plate-solving. * Docker services (``config-server`` and ``pocs-control``) are started in ``global`` mode so there can be only one. * Config changed to run with simulators out of the box. * Removing old scripts and config files. * Simplify testing service by removing ``tests/env`` file. * The default ``radius`` for solving images is 15°. ## Related Issue Needed by #1071, #1072
|
Closing in favour of #1069 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
infolevel is made when an observation is taken without a filter specified (filter_name=None).filter_name=Noneis always (and necessarily) specified.