Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arduino board cleanups #1035

Merged
merged 6 commits into from
Nov 14, 2020
Merged

Arduino board cleanups #1035

merged 6 commits into from
Nov 14, 2020

Conversation

wtgee
Copy link
Member

@wtgee wtgee commented Nov 13, 2020

We have traditionally used a series of different Arduino sketches to handle the various electronics boards that we have. Each of these was customized to the specific board, one for each iteration of the hardware. These have had many different names and has generally been very confusing.

Going forward we will be using the Firmata framework to abstract the functionality of each board, moving the logic off the arduino and onto Python.

We will be implementing this with a slight variation of the standard Firmata sketch via Firmata Express, which provides additional features, including board discovery, watchdog features, etc.

Installation instructions will be located at: https://projectpanoptes.gitbook.io/pocs-user-guide/building/software/power-distribution-arduino-software

Description

  • Clearing out all the arduino files that are specific to a certain board.
  • Clearing out the tests and supporting files. Some of this might be re-introduced in a different fashion using Firmata.

Related Issue

Closes #310
Closes #318
Closes #322
Closes #326
Closes #339
Closes #964

How Has This Been Tested?

This is mostly a cleanup PR to remove existing files. Specific tests will follow on actual hardware before PR merge.

…oard.

* Clearing out the tests and supporting files. Some of this might be re-introduced in a different fashion using Firmata.
@wtgee wtgee added the arduino label Nov 13, 2020
@codecov
Copy link

codecov bot commented Nov 13, 2020

Codecov Report

Merging #1035 (c24d6f4) into develop (c02070a) will increase coverage by 2.06%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1035      +/-   ##
===========================================
+ Coverage    85.22%   87.29%   +2.06%     
===========================================
  Files           75       72       -3     
  Lines         6404     6054     -350     
  Branches       592      544      -48     
===========================================
- Hits          5458     5285     -173     
+ Misses         792      620     -172     
+ Partials       154      149       -5     
Impacted Files Coverage Δ
src/panoptes/peas/tests/test_sensors.py 100.00% <ø> (ø)
src/panoptes/pocs/focuser/focuser.py 72.28% <0.00%> (-2.01%) ⬇️
src/panoptes/pocs/camera/camera.py 82.45% <0.00%> (-0.51%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c02070a...c24d6f4. Read the comment docs.

@wtgee wtgee merged commit 5578e3b into panoptes:develop Nov 14, 2020
@wtgee wtgee deleted the arduino-cleanup branch November 14, 2020 18:38
@wtgee wtgee mentioned this pull request Nov 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
1 participant