Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintain dependencies in setup.py #908

Closed
wtgee opened this issue Oct 14, 2019 · 3 comments
Closed

Maintain dependencies in setup.py #908

wtgee opened this issue Oct 14, 2019 · 3 comments
Milestone

Comments

@wtgee
Copy link
Member

wtgee commented Oct 14, 2019

Move dependency list to setup.py and use use the pip-compile tool introduced in #907 to generate requirements.txt.

Describe the solution you'd like
The definitive list of dependencies should be kept in setup.py to be compatible with setuptools but there should also exist a requirements.txt version for pip installing.

#907 introduced the use of pip-compile (from pip-tools) for auto-generating the requirements.txt file from a requirements.in file. We should instead keep the list of dependencies directly in setup.py and remove the requirements.in file completely.

Related Issues/PRs
#907

@wtgee wtgee modified the milestones: v0.7.0, v0.8.0 Oct 14, 2019
@capsulecorplab
Copy link
Contributor

capsulecorplab commented Oct 30, 2019

This is also achievable with the pip-tools toolchain; If the dependency list is specified in an install_requires in setup.py, then you can generate requirements.txt from setup.py, using pip-compile without any arguments, or pip-compile --output-file requirements.txt setup.py to update.
See requirements-from-setuppy

This also happens to be the recommended configuration by the PyPA User Guide 🙂
https://packaging.python.org/discussions/install-requires-vs-requirements/

@wtgee
Copy link
Member Author

wtgee commented Oct 30, 2019

This is also achievable with the pip-tools toolchain; If the dependency list is specified in an install_requires in setup.py, then you can generate requirements.txt from setup.py, using pip-compile without any arguments, or pip-compile --output-file requirements.txt setup.py to update.
See requirements-from-setuppy

This also happens to be the recommended configuration by the PyPA User Guide
https://packaging.python.org/discussions/install-requires-vs-requirements/

Thanks @capsulecorplab, that's what I did for a different repo, I just need to clean this one up a bit before. Cheers!

@wtgee
Copy link
Member Author

wtgee commented Feb 13, 2020

This was completed as part of #937

@wtgee wtgee closed this as completed Feb 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants