Skip to content
This repository has been archived by the owner on Oct 18, 2024. It is now read-only.

[New feature]Don't download subtitles if audio is in %language #519

Closed
ghost opened this issue May 24, 2018 · 7 comments
Closed

[New feature]Don't download subtitles if audio is in %language #519

ghost opened this issue May 24, 2018 · 7 comments
Labels
enhancement fixed in upcoming version

Comments

@ghost
Copy link

ghost commented May 24, 2018

Hi,

Is it possible to add option to not searching for subtitles if audio is in the same language as requested sub?

Example:

  1. Subtitles primary language to search: PL in Sub-Zero options

One of the track in file is in pl language so don't try to search for subtitles
@pannal
Copy link
Owner

pannal commented May 25, 2018

Yep.

pannal added a commit that referenced this issue Jun 17, 2018
@pannal
core: add support for downloading subtitles only when the audio strea…
6135020 
…ms don't match (any?) configured languages; fixes #519
@pannal
Copy link
Owner

pannal commented Jun 17, 2018

@Haxy89 I've pushed exactly that feature to the current develop-2.5 branch. Care to try?

pannal added a commit that referenced this issue Jun 17, 2018
@pannal
#519 fix pref strings
1e11e85
@ghost
Copy link
Author

ghost commented Jun 17, 2018

I will check

@pannal
Copy link
Owner

pannal commented Jun 17, 2018

Do you need help with that?

@ghost
Copy link
Author

ghost commented Jun 18, 2018

No, just give me one or two days to check that

@ghost
Copy link
Author

ghost commented Jun 18, 2018

Works for me on DEV

log.txt

@pannal
Copy link
Owner

pannal commented Jun 18, 2018

Thanks for testing!

pannal added a commit that referenced this issue Sep 3, 2018
@pannal
#519 fix pref strings
8d9c9bb
@pannal pannal closed this as completed in 4e3f1a9 Nov 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement fixed in upcoming version
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pannal